[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/2] pvh: clearly specify used parameters in vcpu_guest_context

On 20/11/13 10:29, Roger Pau Monnà wrote:
On 20/11/13 10:54, Jan Beulich wrote:
On 20.11.13 at 10:37, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
On 20/11/13 10:28, Jan Beulich wrote:
On 20.11.13 at 10:18, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
On 19/11/13 17:53, Jan Beulich wrote:
On 19.11.13 at 17:42, Roger Pau MonnÃ<roger.pau@xxxxxxxxxx> wrote:
Trying to make all those fields functional on PVH (or HVM) is quite
useless IMHO, it's going to add more code that I doubt anyone is going
to use when you can instead use the bare metal functions to set all
those things (and from an OS point of view it's also more comfortable
because you need less Xen specific stuff).
That last part I certainly agree to, but that would apply to CR0
and CR4 just as much.
I've removed the usage of anything that's not strictly necessary in
order to do AP bringup, so I've removed the setting of debugregs:
You can't - this code is also used for HVM guests.
Yes, my fault, I erroneously thought this was introduced by 35b1e076,
but it has been there longer than that. Would you agree to a patch
similar to the one posted, but without touching the setting of debugregs?
Yes, if Mukesh and George confirm that this is not going to break
Here it is:

 From dc19632f361b2737791821232ce9b38508f1cd7f Mon Sep 17 00:00:00 2001
From: Roger Pau Monne <roger.pau@xxxxxxxxxx>
Date: Thu, 14 Nov 2013 18:07:51 +0100
Subject: [PATCH v3] pvh: clearly specify used parameters in
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The aim of this patch is to define a stable way in which PVH is
going to do AP bringup.

Since we are running inside of a HVM container, PVH should only need
to set flags, cr3 and user_regs in order to bring up a vCPU, the rest
can be set once the vCPU is started using the bare metal methods.

Signed-off-by: Roger Pau Monnà <roger.pau@xxxxxxxxxx>

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

Release-wise, this only affects PVH codepaths, so should be fine.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.