Re: [Xen-devel] [PATCH 03/16] tmem: cleanup: rm unused tmem_op

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 25.11.13 at 10:52, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote:
> On Mon, 2013-11-25 at 09:43 +0000, Jan Beulich wrote:
>> >>> On 22.11.13 at 18:38, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 
>> >>> wrote:
>> > On Wed, Nov 20, 2013 at 04:46:12PM +0800, Bob Liu wrote:
>> >> TMEM_READ/TMEM_WRITE/TMEM_XCHG/TMEM_NEW_PAGE are never be used.
>> > 
>> > You also need to delete them in include/public/tmem.h and rev up the
>> > TMEM_SPEC_VERSION I think?
>> 
>> I said this elsewhere already - you can't simply delete things
>> from the public interface.
> 
> Should 006a687ba4de74d7933c09b43872abc19f126c63 be partially reverted
> then, to reinstate the typedef under a suitable #ifdef
> __XEN_INTERFACE_VERSION__ ?

Yes, that would be my recommendation. But Konrad as the tmem
maintainer should voice his opinion before we do that.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel