Re: [Xen-devel] [PATCH v3 04/13] xen: arm: add a quirk to handle platforms with unusual GIC layout

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2013-11-25 at 12:34 +0000, Julien Grall wrote:
> > +    if ( platform_has_quirk(PLATFORM_QUIRK_GIC_64K_STRIDE) )
> > +        ret = map_mmio_regions(d, d->arch.vgic.cbase + PAGE_SIZE,
> > +                               d->arch.vgic.cbase + (2 * PAGE_SIZE) - 1,
> > +                               gic.vbase + PAGE_SIZE);
> > +    else
> > +        ret = map_mmio_regions(d, d->arch.vgic.cbase + PAGE_SIZE,
> > +                               d->arch.vgic.cbase + (2 * PAGE_SIZE) - 1,
> > +                               gic.vbase + 16*PAGE_SIZE);
> 
> The condition needs to be inverted here ... the CPU second page is at 
> 64K only on platform where the quirk is enabled.

Doh! Shows how much use Linux makes of the secnd page of registers (i.e.
none!)

Ian.




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel