[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 04/16] tmem: cleanup: rm unneeded parameters from put path

On 11/23/2013 01:54 AM, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 20, 2013 at 04:46:13PM +0800, Bob Liu wrote:
>> tmem only takes a page as unit, so parameters tmem_offset, pfn_offset and len
>> are meanless, this patch remove those parameters from do_tmem_put() related 
>> path
>       ^^^^^^^^                   ^-s
> Not exactly right. They were used by TMEM_WRITE and TMEM_READ, but your
> other patch "tmem: cleanup: rm unused tmem_op" removed them.
> Looking a bit on Google I see this thread:
> http://marc.info/?l=xen-devel&m=136975816209598
> which implies that the Windows GPL driver is using it? Did you
> check its code? (See http://xenbits.xen.org/ext/win-pvdrivers/)

Okay, I'll check the Windows drivers.

> If it is not in the code, can you also CC James Harper on it so
> he knows not use those ops?



Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.