Re: [Xen-devel] [PATCH 0/4] ARM: add PSCI host support

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2013-11-27 at 14:45 +0100, Andre Przywara wrote:
> On 11/26/2013 12:05 PM, Ian Campbell wrote:
> > On Mon, 2013-11-25 at 13:02 +0100, Andre Przywara wrote:
> >> Xen did not make use of the host provided ARM PSCI (Power State
> >> Coordination Interface) functionality so far, but relied on platform
> >> specific SMP bringup functions.
> >> This series adds support for PSCI on the host by reading the required
> >> information from the DTB and invoking the appropriate handler when
> >> bringing up each single CPU.
> >> Since PSCI is defined for both ARM32 and ARM64, I put the code in a
> >> file shared by both.
> >> The ARM32 code was tested on Midway, but the ARM64 code was compile
> >> tested only.
> >>
> >> This approach seems to be the least intrusive, but one could also use
> >> more of the current ARM64 code by copying the PSCI/spin-table
> >> distinction code to a shared file and use that from both
> >> architectures. However that seems more complicated.
> 
> Ian,
> 
> thanks for the review and for the willingness to take the patches for 
> 4.4 still. Will address the comments ASAP.
> 
> > I don't think that is needed (since armv7 spintable vs armv8 spintable
> > mechanisms are a bit different). But I would like to see the psci code
> > in a separate psci.c. It's not much code right now but it will likely
> > grow.
> 
> But there is already a xen/arch/arm/psci.c file, which holds the two 
> functions to bring up/take down vCPUs.

Ah, sorry, I didn't know about this.

This file should be called vpscsi.c IMHO with the non-v version for the
host stuff. Do you mind renaming as you go?

[...]
> And beside that there is quite some other (only guest related) code in 
> Xen which simply uses *psci* in identifiers and filenames (like 
> asm/psci.h), that's why I used the psci_host prefix to tell them apart.

Urk. I think the #defines are common since they are part of the spec and
the do_pscsi could stand being do_vpscsi. Probably no need for vpsci.h
here.

I seem to be unable to type PSCI without typing PSCSI instead today,
sorry...

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel