Re: [Xen-devel] [PATCH v5 00/12] libxl: ocaml: improve the bindings

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 11/27/2013 11:39 AM, Rob Hoes wrote:
> Ian Campbell wrote:
> > On Tue, 2013-11-26 at 17:52 +0000, Rob Hoes wrote:
> > > This series contains version 5 of the remaining patches to fix the
> > > OCaml bindings to libxl.
> > Since we are now into the freeze period we (really, you ;-) need to make
> > an argument to the release manager (George) for why this should go in now.
> > His guidance is in
> > http://article.gmane.org/gmane.comp.emulators.xen.devel/180209.
> >
> > The benefit of this series is that it allows for ocaml based xen
> > toolstacks (specifically xapi) to start making the transition to using
> > libxl. It would be awesome if 4.4 provided a decent baseline for that.
> I would indeed be great if we can start using libxl from Xen 4.4 out of the box!
>
> > The risk is that we break the bindings for some existing users, but I am
> > 99.9% certain there can be none of those. Effectively Rob is the only user
> > today. The bindings in 4.3 were not really usable, at least not in anger.
> I don't think anyone would have been really able to use the bindings as they 
> were, because they were incomplete and caused memory corruption. In a way, you 
> could consider the whole series to be one large bug fix :)
>
> About 80% of my original series has already been merged. This contained really 
> just the ground work. This version adds some essential bindings to VM lifecycle 
> operations, the event system, and some bug fixes. These patches only affect 
> files in tools/ocaml (plus .git/.hgignore).
I agree with the cost/benefit analysis.  Assuming that it's accurate 
that the changes are confined to tools/ocaml:
Release-acked-by: George Dunlap <george.dunlap@xxxxxxxxxxxxx>

 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel