Re: [Xen-devel] [PATCH 1/4] common/vsprintf: Explicitly treat negative lengths as 'unlimited'

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/11/13 16:37, Tim Deegan wrote:
> The old code relied on implictly casting negative numbers to size_t
> making a very large limit, which was correct but non-obvious.
>
> Coverity CID 1128575
>
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This CID was introduced as a side effect of my %ps/%pS series, which was
basically code motion for this piece.  The previous code was not exactly
fantastic.

> ---
>  xen/common/vsprintf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/xen/common/vsprintf.c b/xen/common/vsprintf.c
> index 43dc392..68553bb 100644
> --- a/xen/common/vsprintf.c
> +++ b/xen/common/vsprintf.c
> @@ -239,7 +239,7 @@ static char *number(
>  static char *string(char *str, char *end, const char *s,
>                      int field_width, int precision, int flags)
>  {
> -    int i, len = strnlen(s, precision);
> +    int i, len = (precision < 0) ? strlen(s) : strnlen(s, precision);
>  
>      if (!(flags & LEFT)) {
>          while (len < field_width--) {


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel