Re: [Xen-devel] [PATCH 3/4] x86/mem_sharing: drop unused variable.

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/11/13 16:37, Tim Deegan wrote:
> Coverity CID 1087198
>
> Signed-off-by: Tim Deegan <tim@xxxxxxx>

Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> ---
>  xen/arch/x86/mm/mem_sharing.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/xen/arch/x86/mm/mem_sharing.c b/xen/arch/x86/mm/mem_sharing.c
> index 1e89f6c..8355f94 100644
> --- a/xen/arch/x86/mm/mem_sharing.c
> +++ b/xen/arch/x86/mm/mem_sharing.c
> @@ -833,7 +833,6 @@ int mem_sharing_nominate_page(struct domain *d,
>      mfn_t mfn;
>      struct page_info *page = NULL; /* gcc... */
>      int ret;
> -    struct gfn_info *gfn_info;
>  
>      *phandle = 0UL;
>  
> @@ -892,7 +891,7 @@ int mem_sharing_nominate_page(struct domain *d,
>      page->sharing->handle = get_next_handle();  
>  
>      /* Create the local gfn info */
> -    if ( (gfn_info = mem_sharing_gfn_alloc(page, d, gfn)) == NULL )
> +    if ( mem_sharing_gfn_alloc(page, d, gfn) == NULL )
>      {
>          xfree(page->sharing);
>          page->sharing = NULL;


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel