Re: [Xen-devel] [PATCH v12 03/18] xen/pvh: Early bootup changes in PV code (v2).

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 02/01/14 18:32, Konrad Rzeszutek Wilk wrote:
> On Thu, Jan 02, 2014 at 03:32:33PM +0000, David Vrabel wrote:
>> On 01/01/14 04:35, Konrad Rzeszutek Wilk wrote:
>>> From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
>>>
>>> In the bootup code for PVH we can trap cpuid via vmexit, so don't
>>> need to use emulated prefix call. We also check for vector callback
>>> early on, as it is a required feature. PVH also runs at default kernel
>>> IOPL.
>>>
>>> Finally, pure PV settings are moved to a separate function that are
>>> only called for pure PV, ie, pv with pvmmu. They are also #ifdef
>>> with CONFIG_XEN_PVMMU.
>> [...]
>>> @@ -331,12 +333,15 @@ static void xen_cpuid(unsigned int *ax, unsigned int 
>>> *bx,
>>>             break;
>>>     }
>>>  
>>> -   asm(XEN_EMULATE_PREFIX "cpuid"
>>> -           : "=a" (*ax),
>>> -             "=b" (*bx),
>>> -             "=c" (*cx),
>>> -             "=d" (*dx)
>>> -           : "0" (*ax), "2" (*cx));
>>> +   if (xen_pvh_domain())
>>> +           native_cpuid(ax, bx, cx, dx);
>>> +   else
>>> +           asm(XEN_EMULATE_PREFIX "cpuid"
>>> +                   : "=a" (*ax),
>>> +                   "=b" (*bx),
>>> +                   "=c" (*cx),
>>> +                   "=d" (*dx)
>>> +                   : "0" (*ax), "2" (*cx));
>>
>> For this one off cpuid call it seems preferrable to me to use the
>> emulate prefix rather than diverge from PV.
> 
> This was before the PV cpuid was deemed OK to be used on PVH.
> Will rip this out to use the same version.
> 
>>
>>> @@ -1431,13 +1449,18 @@ asmlinkage void __init xen_start_kernel(void)
>>>  
>>>     xen_domain_type = XEN_PV_DOMAIN;
>>>  
>>> +   xen_setup_features();
>>> +   xen_pvh_early_guest_init();
>>>     xen_setup_machphys_mapping();
>>>  
>>>     /* Install Xen paravirt ops */
>>>     pv_info = xen_info;
>>>     pv_init_ops = xen_init_ops;
>>> -   pv_cpu_ops = xen_cpu_ops;
>>>     pv_apic_ops = xen_apic_ops;
>>> +   if (xen_pvh_domain())
>>> +           pv_cpu_ops.cpuid = xen_cpuid;
>>> +   else
>>> +           pv_cpu_ops = xen_cpu_ops;
>>
>> If cpuid is trapped for PVH guests why does PVH need non-native cpuid op?
> 
> There are a couple of filtering done on the cpuid. But with HVM I am
> not entirely sure if it is worth preserving those or not.

I think we should behave like HVM for cpuid and any cpuid
policy/filtering should be set up by the toolstack.

> My fear is that if we switch over to the native one without the
> filtering that the kernel does we open up a can of worms that had been
> closed in the past. The reason is that for dom0 - there is no cpuid
> filtering being done. So it gets everything that the hypervisor sees.

I think we should switch to using the native cpuid pv-op and fix up any
problems as we encounter them (by fixing the toolstack to set up the
cpuid stuff properly).

dom0 isn't supported yet so that's not an issue.  In the future dom0
could be handled by either: a) setting the cpuid policy in the
hypervisor during dom0 create; or b) the kernel can set this up during
early boot.  In both cases using native cpuid should do the right thing.

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel