Re: [Xen-devel] [PATCH v12 08/18] xen/pvh: Load GDT/GS in early PV bootup code for BSP.

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 02/01/14 18:24, Konrad Rzeszutek Wilk wrote:
>>> +           loadsegment(es, 0);
>>> +           loadsegment(ds, 0);
>>> +           loadsegment(fs, 0);
>>> +#else
>>> +           /* PVH: TODO Implement. */
>>> +           BUG();
>>> +#endif
>>> +           return;    <==============
>>> +   }
>>>     pv_cpu_ops.write_gdt_entry = xen_write_gdt_entry_boot;
>>>     pv_cpu_ops.load_gdt = xen_load_gdt_boot;
>>
>> If PVH uses native GDT why are these (and possibly other?) GDT ops needed?
> 
> They aren't. There is a 'return' there. I marked it for you with
> '<======'.

I missed that, in which case.

Reviewed-by: David Vrabel <david.vrabel@xxxxxxxxxx>

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel