Re: [Xen-devel] global keymap= option not recognized

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Jan 09, 2014 at 11:59:44AM +0000, Ian Campbell wrote:
> On Thu, 2014-01-09 at 11:52 +0000, Wei Liu wrote:
> > On Thu, Jan 09, 2014 at 10:04:51AM +0000, Ian Campbell wrote:
> > > On Wed, 2014-01-08 at 18:34 +0000, Wei Liu wrote:
> > > > On Wed, Jan 08, 2014 at 04:51:40PM +0000, Ian Campbell wrote:
> > > > > On Wed, 2014-01-08 at 17:46 +0100, Olaf Hering wrote:
> > > > > > With xm it was possible to have a global keymap="de" to map the 
> > > > > > physical
> > > > > > keybard correctly. Now with xl this fails, at least in xen-4.3.
> > > > > > xl create -d shows keymap:NULL in the vfb part.
> > > > > > Only moving keymap= into vfb=[] fixes it for me.
> > > > > > 
> > > > > > xl.cfg(5) indicates that keymap= can be specified as global option 
> > > > > > (just
> > > > > > like vnc=) as well as suboption for vbf=[]. 
> > > > > > 
> > > > > > Was this already fixed in xen-unstable? git log shows not keymap 
> > > > > > related
> > > > > > changes.
> > > > > 
> > > > > I don't think Wei covered this one with his VNC patches. It does sound
> > > > > like it should be move though, yes. I think this is 4.5 material at 
> > > > > this
> > > > > point.
> > > > > 
> > > > 
> > > > You're right, my patch didn't cover that aspect because I tried hard to
> > > > make it minimal.
> > > 
> > > Do you think you could revisit this bit for 4.5?
> > > 
> > 
> > Yes, I think so. That should be relatively straightfoward, I hope. :-)
> > 
> > > > > Wei, BTW, did you VNC change not require any doc (e.g. manpage) 
> > > > > updates?
> > > > > Sorry for not thinking of that during review.
> > > > > 
> > > > 
> > > > I don't think so. All VNC / VFB options are already documented.
> > > 
> > > The top level vnc*= options seem to be under "Emulated VGA Graphics
> > > Device" though.
> > > 
> > 
> > How about this
> 
> HRM, I was more thinking about pulling those options out into a new
> "Primary Graphics Device" or something section with a little intro blurb
> about how for PV this is a PVFB and for HVM this is an emulated VNC.
> 
> With your approach I think at a minimum it would need to enumerate which
> specific options work for both.
> 

From 935b18da7a9cf60186a87dcf97d39722d0e49937 Mon Sep 17 00:00:00 2001
From: Wei Liu <wei.liu2@xxxxxxxxxx>
Date: Thu, 9 Jan 2014 11:48:13 +0000
Subject: [PATCH] docs/man/xl.cfg.pod.5: document global VNC options for VFB
 device

Update xl.cfg to reflect change in 706d4ab74 "xl: create VFB for PV
guest when VNC is specified".

Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
---
 docs/man/xl.cfg.pod.5 |    5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
index 72efd88..9941395 100644
--- a/docs/man/xl.cfg.pod.5
+++ b/docs/man/xl.cfg.pod.5
@@ -387,7 +387,10 @@ to the domain.
 
 This options does not control the emulated graphics card presented to
 an HVM guest. See L<Emulated VGA Graphics Device> below for how to
-configure the emulated device.
+configure the emulated device. If L<Emulated VGA Graphics Device> options
+are used in a PV guest configuration, xl will pick up B<vnc>, B<vnclisten>,
+B<vncpasswd>, B<vncdisplay> and B<vncunused> to construct paravirtual
+framebuffer device for the guest.
 
 Each B<VFB_SPEC_STRING> is a comma-separated list of C<KEY=VALUE>
 settings, from the following list:
-- 
1.7.10.4



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel