[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] xen/malloc: handle correctly page allocation when align > size

On 07/03/14 10:06, Jan Beulich wrote:
On 07.03.14 at 07:46, Julien Grall <julien.grall@xxxxxxxxxx> wrote:
When align is superior to size, we need to retrieve the order from
align during multiple page allocation. I guess it was the goal of the commit
fb034f42 "xmalloc: make close-to-PAGE_SIZE allocations more efficient".

Oh, yes, of course it was. Without that the call is pointless.

Signed-off-by: Julien Grall <julien.grall@xxxxxxxxxx>

Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>

Albeit in fact the better change might be to simply use
max(size, align) in the initializer of order - no idea why I didn't do
it that way.

I can send a new version of this page to use max.

Out of curiosity: I never expected this code path to be actually
taken - what is it that you need this to work correctly?

I was looking to the code to decide if the best solution is to use xmalloc or alloc_xenheap_pages directly.

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.