Re: [Xen-devel] [PATCH 09/11] tools/xc: pass errno to callers of xc_domain_save

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [PATCH 09/11] tools/xc: pass errno to callers of 
xc_domain_save"):
> On Mon, Mar 10, Ian Jackson wrote:
> 
> > Yes, except the temporary should be called "error_macro_errno" or
> > something.
> 
> I have changed it, now it looks like this:
> 
> +#define PERROR(_m, _a...) do { int PERROR_errno = errno; \
> +        xc_report_error(xch,XC_INTERNAL_ERROR,_m " (%d = %s)", \
> +        ## _a , errno, xc_strerror(xch, errno)); \
> +        errno = PERROR_errno; \
> +        } while (0)

That looks fine to me.

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel