Re: [Xen-devel] [PATCH 5/6] pci: Use #defines for PCI vendors.

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 11.03.14 at 16:15, Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> On Tue, Mar 11, 2014 at 08:35:38AM +0000, Jan Beulich wrote:
>> >>> On 10.03.14 at 20:35, Konrad Rzeszutek Wilk <konrad@xxxxxxxxxx> wrote:
>> > --- /dev/null
>> > +++ b/xen/include/xen/pci_ids.h
>> > @@ -0,0 +1,9 @@
>> > +#define PCI_VENDOR_ID_AMD                0x1022
>> > +
>> > +#define PCI_VENDOR_ID_BROADCOM           0x14e4
>> > +
>> > +#define PCI_VENDOR_ID_INTEL              0x8086
>> > +
>> > +#define PCI_VENDOR_ID_NVIDIA             0x10de
>> > +
>> > +#define PCI_VENDOR_ID_OXSEMI             0x1415
>> 
>> If I'm going to be the one to commit this (and I don't forget), I'll
>> take the liberty of sorting these numerically, matching Linux and
>> making imo lookup easier, since especially considering company
>> acquires/mergers the name to look for may be ambiguous.
> 
> Of course. I think I am depending on you to merge them as I don't
> have the commit access.
> 
> If you would like, I can pluck them in a git tree with this above
> fixed and your Reviewed-by added and I can just send you a GIT PULL
> request.

I don't think that would help much, not the least because we'll have
to wait for Keir's ack first anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel