Re: [Xen-devel] [PATCH] systemd: add support initial systemd service files

["Luis R. Rodriguez" <mcgrof@xxxxxxxxxxxxxxxx>]

On Wed, Mar 12, 2014 at 12:44 PM, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
>>>
>>> https://github.com/pld-linux/xen/blob/master/xen-watchdog.service
>>> https://github.com/pld-linux/xen/blob/master/xenconsoled.service
>>> https://github.com/pld-linux/xen/blob/master/xendomains.service
>>> https://github.com/pld-linux/xen/blob/master/xenstored.service


I have reviewed these and they seem to be a good step forward but I
think there's two things needed:

  * Modify upstream xen to stash things into environment variable
files for systmed depending on the system configuration upon
./configure. xen already does this and stashes stuff into
/etc/xen/scripts/hotplugpath.sh. I tried to modify these with what I
got on my configuration with defaults and I get for example:

SBINDIR=/usr/local/sbin
BINDIR=/usr/local/bin
LIBEXEC=/usr/local/lib/xen/bin
LIBDIR="/usr/local/lib64
SHAREDIR=/usr/local/share
PRIVATE_BINDIR=/usr/local/lib64/xen/bin
XENFIRMWAREDIR=/usr/local/lib/xen/boot
XEN_CONFIG_DIR=/etc/xen
XEN_SCRIPT_DIR=/etc/xen/scripts
XEN_LOCK_DIR=/var/lock
XEN_SYSTEMD_DIR=/usr/local/lib/systemd/system/
XEN_RUN_DIR=/var/run/xen
XEN_PAGING_DIR=/var/lib/xen/xenpaging

In this case I used the scripts's hints and stashed these into
/etc/sysconfig/xenstored. I then relied on the
EnvironmentFile=-/etc/sysconfig/xenstored you use and modified the
Exec parts as follows:

ExecStartPre=/bin/grep -q control_d /proc/xen/capabilities
ExecStartPre=-/bin/rm -f "$XENSTORED_ROOTDIR"/tdb*
ExecStart=$SBINDIR/xenstored --pid-file "$XEN_RUN_DIR"/xenstored.pid
$XENSTORED_ARGS
ExecStartPost=$BINDIR/xenstore-write "/local/domain/0/name" "Domain-0"

But this didn't seem to work, I suppose I'm not using the variables correctly.

  * You seem to have split out xendomains functionality into
/usr/lib/xen/bin/xendomains.sh, this would need an equivalent path to
help configurations that differ to be respected and for the changes
needed to split this to go upstream into xen

  Luis

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel