Re: [Xen-devel] [PATCH 4/5] xen/arm: Cleanup use of __attribute__((packed))

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-13 at 10:59 +0100, Tim Deegan wrote:
> At 09:55 +0000 on 13 Mar (1394700902), Ian Campbell wrote:
> > On Thu, 2014-03-13 at 08:34 +0000, Jan Beulich wrote:
> > > >>> On 12.03.14 at 20:08, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote:
> > > > And standardise on having the statement at the head of the struct/union 
> > > > rather
> > > > than at the tail.  This is all mechanical shuffling.
> > > 
> > > Yet none of the attributes seem really necessary here.
> > 
> > These structs mirror the actual hardware PTE layouts, although it should
> > make no difference in practice isn't __packed quite a useful indicator
> > for this?
> 
> +1.  I think that __packed on things where the actual bit layout is
> important is fine, even if it's not strictly necessary.

Therefore for the original patch:
Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Ian.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel