[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH 4/5] xen/arm: Cleanup use of __attribute__((packed))
>>> On 13.03.14 at 10:55, Ian Campbell <Ian.Campbell@xxxxxxxxxx> wrote: > On Thu, 2014-03-13 at 08:34 +0000, Jan Beulich wrote: >> >>> On 12.03.14 at 20:08, Andrew Cooper <andrew.cooper3@xxxxxxxxxx> wrote: >> > And standardise on having the statement at the head of the struct/union >> > rather >> > than at the tail. This is all mechanical shuffling. >> >> Yet none of the attributes seem really necessary here. > > These structs mirror the actual hardware PTE layouts, although it should > make no difference in practice isn't __packed quite a useful indicator > for this? Yes - see my respective comments elsewhere on this series. All I'm asking Andrew for is to get this done consistently: Either retain the attribute on everything defining interfaces to lower level entities (hardware/firmware), or drop them everywhere where they don't serve a purpose beyond documentation. Jan _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |