Re: [Xen-devel] [PATCH 1/5] xen: Remove redundant __attribute__((packed)) statements

[George Dunlap <george.dunlap@xxxxxxxxxxxxx>]

On 03/12/2014 07:08 PM, Andrew Cooper wrote:
> All of these structure packing statements are redundant, and was confirmed by
> diffing xen-syms with and without the change in place.
>
> Removing struct xgt_desc in its entirety (as it was unreferenced) results in
> shuffling the symbol index, but makes no change to the code.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
I guess I'm becoming a crotchety old maintainer; at least re the tracing 
code, I don't see how the cost -- your initial effort in figuring out 
which structures need packing, the cost of review time, and the risk of 
regression, no matter how small -- is worth the benefit.  It seems to me 
like having all the tracing structures tagged with "__packed" will 
remind people to think about packing when they're writing or modifying 
structures.
But if Jan and/or Keir think it's a good idea, and are satisfied that 
it's correct, I won't oppose it.
 -George


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel