[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 5/5] xen/x86_emulate: Shuffle use of __attribute__((packed))

Andrew Cooper wrote:

Also include #defines for the test code to allow compilation.

Signed-off-by: Andrew Cooper<andrew.cooper3@xxxxxxxxxx>
CC: Keir Fraser<keir@xxxxxxx>
CC: Jan Beulich<JBeulich@xxxxxxxx>
CC: Ian Campbell<Ian.Campbell@xxxxxxxxxx>
CC: Ian Jackson<Ian.Jackson@xxxxxxxxxxxxx>


I have mixed thoughts about this, which is why it is explicit separated from
the rest of the series.  On the one hand, consistency is good but on the
other, it makes x86_emulate harder to use as a dropin in other code.

We already have a bunch of external definitions that must be provided for x86_emulate.c. This merely adds another, but which is required for x86_emulate.h. So it's perfectly fine by me.

Acked-by: Keir Fraser <keir@xxxxxxx>
Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.