Re: [Xen-devel] [PATCH] tools/libxc: fix errno handling for HVM in xc_domain_save

[Olaf Hering <olaf@xxxxxxxxx>]

On Thu, Mar 13, Ian Jackson wrote:

> Olaf Hering writes ("[PATCH] tools/libxc: fix errno handling for HVM in 
> xc_domain_save"):
> > The previous patch ("tools/libxc: pass errno to callers of
> > xc_domain_save") did not jump to the proper label if the domU is HVM.
> > 
> > Also make it clearer what "out" and "out_rc" are supposed to mean:
> > label "out" is for failure case, it expects errno to be set.
> > label "out_rc" is for success case, it preserves the initial errno for
> > the caller.
> 
> I agree with Ian that this is very confusing.  How about this instead ?

That would fix the current bug, yes.

Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel