Re: [Xen-devel] [PATCH] tools/libxc: fix errno handling for HVM in xc_domain_save

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Olaf Hering writes ("Re: [PATCH] tools/libxc: fix errno handling for HVM in 
xc_domain_save"):
> On Thu, Mar 13, Ian Jackson wrote:
> > I agree with Ian that this is very confusing.  How about this instead ?
> 
> That would fix the current bug, yes.

Thanks for the review.  I have pushed this, in the form below.

Ian.

commit 29f0712bc008a9d6e611785424f797cfc185c1d3
Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date:   Thu Mar 13 17:59:49 2014 +0000

    tools/libxc: fix errno handling for HVM in xc_domain_save
    
    The previous patch (dda0b77d "tools/libxc: pass errno to callers of
    xc_domain_save") did not jump to the proper label if the domU is HVM.
    
    Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
    Reviewed-by: Olaf Hering <olaf@xxxxxxxxx>

diff --git a/tools/libxc/xc_domain_save.c b/tools/libxc/xc_domain_save.c
index 9f96bb7..71f9b59 100644
--- a/tools/libxc/xc_domain_save.c
+++ b/tools/libxc/xc_domain_save.c
@@ -1836,8 +1836,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t 
dom, uint32_t max_iter
         }
         
         /* HVM guests are done now */
-        errno = 0;
-        goto out;
+        goto success;
     }
 
     /* PV guests only from now on */
@@ -2037,6 +2036,7 @@ int xc_domain_save(xc_interface *xch, int io_fd, uint32_t 
dom, uint32_t max_iter
     }
 
     /* Success! */
+ success:
     rc = errno = 0;
     goto out_rc;
 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel