[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 08/19] libxc: suspend: Fix suspend event channel locking

On Thu, 2014-03-13 at 18:46 +0000, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH 08/19] libxc: suspend: Fix suspend event 
> channel locking"):
> > On Tue, 2014-03-04 at 14:56 +0000, Ian Jackson wrote:
> > > Use fcntl F_SETLK, rather than writing our pid into a "lock" file.
> > > That way if we crash we don't leave the lockfile lying about.  Callers
> > > now need to keep the fd for our lockfile.  (We don't use flock because
> > > we don't want anyone who inherits this fd across fork to end up with a
> > > handle onto the lock.)
> > > 
> > > While we are here:
> > >  * Move the lockfile to /var/run/xen
> > 
> > There isn't some autoconf'y path we should use is there? SUBSYS_DIR,
> > localstatedir etc?
> There does seem to be, but I'm not really convinced that it's the
> right thing.
> > Probably we don't really use those elsewhere so it is consistent to
> > use /var directly here too.
> I did a grep for uses of /var/run in the whole tree, and of /var in
> libxl.  libxl has /var/lib and /var/log hardcoded but not /var/run
> yet.
> But xenstored, xenmon, and many of our scripts, have it hardcoded in
> one way or another.

This rings a bell -- I think when we switch prefix from /usr
to /usr/local we inadvertently ended up moving a load of stuff
to /usr/local/var which was just broken -- so we ended up overriding to
use FHS /var instead of GNU/autoconf $PREFIX/var.

So I think you've done the right thing.

My ack stands.

> So I think this is OK.  Systems which are using /run will have a
> symlink for /var/run.
> Thanks,
> Ian.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.