[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH for-4.5 7/8] xen/irq: Handle multiple action per IRQ

On Tue, 18 Mar 2014, Julien Grall wrote:
> Hi Stefano,
> On 03/18/2014 03:01 PM, Stefano Stabellini wrote:
> >> I understand the point that people can badly use multiple action in the
> >> future, but is it a good reason to make the code more difficult to
> >> understand?
> > 
> > Can't we simply register all the irq handlers at boot time, regardless
> > of whether they are currently used?
> > 
> This code is doing this actually. You need to know if the IRQ is
> represented multiple times in the "interrupts" list or not.

Oh, that's right.

You could rely on request_dt_irq() being able to handle failures
gracefully to make the code easier to read.
Overall I don't think the code is too bad.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.