[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] libxl: Make libxl_exec tolerate foofd<=2

On Tue, 2014-03-18 at 17:08 +0000, Ian Jackson wrote:
> Make passing 0, 1, or 2 as stdinfd, stdoutfd or stderrfd work
> properly.
> Also, document the meaning of the fd arguments.
> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> CC: Roger Pau Monne <roger.pau@xxxxxxxxxx>
> CC: Vasiliy Tolstov <v.tolstov@xxxxxxxxx>

Acked-by: Ian Campbell <Ian.Campbell@xxxxxxxxxx>

(consider s/2/STDERR_FILENO/ perhaps though?)

> + * stdinfd, stdoutfd, stderrfd will be dup2'd onto the corresponding
> + * fd in the child, if they are not -1.  The original copy of the
> + * descriptor will be closed in the child (unless it's 0, 1 or 2).

consider explicit mention of STD{IN,OUT,ERR} for the hard of


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.