[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v3 08/13] xen/passthrough: iommu: Basic support of device tree assignment

On Tue, 2014-03-18 at 19:46 +0000, Julien Grall wrote:
> Hi Ian,
> On 03/18/2014 04:33 PM, Ian Campbell wrote:
> > On Tue, 2014-03-11 at 15:49 +0000, Julien Grall wrote:
> >> Add IOMMU helpers to support device tree assignment/deassignment. This 
> >> patch
> >> introduces 2 new fields in the dt_device_node:
> >>     - is_protected: Does the device is protected by an IOMMU
> >>     - next_assigned: Pointer to the next device assigned to the same
> >>     domain
> > 
> > Am I correct that this list is not maintained for dom0? The behaviour of
> > dt_assign_device and dt_deassign_device seems to rely on it?
> DOM0 will call dt_assign_device for every device protected by the IOMMU
> (see patch #9). So it will itself have a list maintained.

Does this not mean that iommu_assign_dt_device will refuse to assign the
device to another domain (next_assigned list is not empty).

BTW, next_assigned is not a very good name for this list, since the
"nextness" is abstracted away. Consider just device_list.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.