[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [RFC PATCH 2/2] xen: tmem: make tmem aware of NUMA affinity

On Tue, Mar 18, 2014 at 02:29:34PM +0000, Jan Beulich wrote:
> >>> On 18.03.14 at 13:25, Bob Liu <lliubbo@xxxxxxxxx> wrote:
> > Persistant pages in tmem are allocated by alloc_domheap_pages(domain) which
> > is consistent with that domain's node affinity. But that's not true for
> > ephemeral pages, because domain=NULL have to be passed to
> > alloc_domheap_pages(NULL).
> > 
> > This patch makes use of function alloc_domheap_pages_nodemask() introduced 
> > by
> > previous patch, so that we can still only allocate memory from nodes in
> > d->node_affinity even when domain=NULL.
> > 
> > Signed-off-by: Bob Liu <bob.liu@xxxxxxxxxx>
> While this may be considered reasonable, I don't think we want to
> see feature enhancements to tmem prior to the security audit
> having happened that has been outstanding for about 1.5 years
> (XSA-15).

Hey Jan,

Bob has been going through the code to make it easier to understand
and also easier to analyze. As part of that it has already removed
some of the issues that at least Coverity has identified.

While I concur with your that adding this patch right now
might distract from the security aspects, I hope to have the
Coverity not report any issues for tmem. The posting of cleanup
patches that Bob had done in February addressed a lot of them -
and I finally got through them and are testing them.

Now Coverity is not the end answer to static analysis so we are
looking at using other tools to augment this.

The paper and pen methodology - which is what both me and Bob
had been using has been instrumental in the creation of the
cleanup patches to simplify some of the code paths.

It is not complete, but I hope by Xen 4.5 it will be done.

Would you perhaps reconsider reviewing the code that Bob
posted and ignore the committing part of it until a later time
(when tmem has gotten throught the security audit).

> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.