[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care of that
as well.

Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>

+       if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
+               skb_tx_error(to);
+               return -ENOMEM;

I think you should move this down to right before we iterate over the

Looks good otherwise.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.