[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Xen-devel] [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors
- To: Thomas Graf <tgraf@xxxxxxxxxx>, Jesse Gross <jesse@xxxxxxxxxx>, <pshelar@xxxxxxxxxx>, <dev@xxxxxxxxxxxxxxx>
- From: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
- Date: Wed, 19 Mar 2014 21:07:08 +0000
- Cc: netfilter@xxxxxxxxxxxxxxx, Miklos Szeredi <mszeredi@xxxxxxx>, kvm@xxxxxxxxxxxxxxx, "Michael S. Tsirkin" <mst@xxxxxxxxxx>, Jason Wang <jasowang@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxx>, Tom Herbert <therbert@xxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, coreteam@xxxxxxxxxxxxx, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jiri Pirko <jiri@xxxxxxxxxxx>, Paul Durrant <Paul.Durrant@xxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, Florian Westphal <fw@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Daniel Borkmann <dborkman@xxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, netfilter-devel@xxxxxxxxxxxxxxx, Joe Perches <joe@xxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>
- Delivery-date: Wed, 19 Mar 2014 21:07:27 +0000
- List-id: Xen developer discussion <xen-devel.lists.xen.org>
On 19/03/14 20:47, Thomas Graf wrote:
On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it
doesn't
orphan them. Also, it doesn't handle errors, so this patch takes care
of that
as well.
Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>
---
+ if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
+ skb_tx_error(to);
+ return -ENOMEM;
}
I think you should move this down to right before we iterate over the
frags.
I agree, I was mislead by that __skb_fill_page_desc, but now I see it is
actually the head buffer of the source, not a frag from there. And in
case of a failure in skb_copy_bits we can spare an orphan_frag.
Zoli
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
|
