[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors

On 19/03/14 20:47, Thomas Graf wrote:
On 03/19/2014 09:38 PM, Zoltan Kiss wrote:
skb_zerocopy can copy elements of the frags array between skbs, but it
orphan them. Also, it doesn't handle errors, so this patch takes care
of that
as well.

Signed-off-by: Zoltan Kiss <zoltan.kiss@xxxxxxxxxx>

+    if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) {
+        skb_tx_error(to);
+        return -ENOMEM;

I think you should move this down to right before we iterate over the

I agree, I was mislead by that __skb_fill_page_desc, but now I see it is actually the head buffer of the source, not a frag from there. And in case of a failure in skb_copy_bits we can spare an orphan_frag.


Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.