Re: [Xen-devel] [PATCH OSSTEST 2/2] standalone mode convenience frontend

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Ian Campbell writes ("Re: [PATCH OSSTEST 2/2] standalone mode convenience 
frontend"):
> On Thu, 2014-03-20 at 16:31 +0000, Ian Jackson wrote:
> > > +         ./sg-run-job $job 2>&1 | tee logs/$flight/$job.log
> > > + rc=${PIPESTATUS[0]}
> > > + if [ $rc -ne 0 ] ; then
> > > +     echo "FAILED rc=${rc}" >&2
> > > + fi
> > 
> > These 4.5 lines occur twice in this file.  Perhaps another subroutine
> > to handle the logging ?
> 
> Sure. Unless the subroutine call is going to muck with ${PIPSTATUS[0]}
> somehow -- I need to check that.

I was thinking of a subroutine you'd use like this:

    BLAH1=1 BLAH2=2 BLAH3=3 with-logging ./sg-run-job $job

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel