Re: [Xen-devel] [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Thu, Mar 20, 2014 at 04:14:34PM +0000, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH RFC V3 5/7] Introduce ts-debian-hvm-install"):
> > Wei Liu writes ("[PATCH RFC V3 5/7] Introduce ts-debian-hvm-install"):
> > > This is debian hvm guest test case. It resembles ts-redhat-install:
> > > 1. prepare a auto install CD
> > > 2. install debian hvm guest, currently using OVMF
> > > 3. test if the guest is up
> > ...
> > >  ts-debian-hvm-install |  202 
> > > +++++++++++++++++++++++++++++++++++++++++++++++++
> 
> Uh, I am a total snooze today.
> 
> > This script has, I'm afraid, far too much clone-and-hack from
> > ts-redhat-install.
> 
> This is true.
> 

What will you suggest?  One thing I can think of is to move
rewrite_config_nocd to TestSupport.pm. The major body looks
Debian-centric to me.

The process is similar to ts-redhat-install -- they both have prep(),
rewrite etc. But inside the prep() function there are actually many
differences.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel