Re: [Xen-devel] [PATCH OSSTEST] cri-args-hostlists: Allow environment to control OSSTEST_CONFIG

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Wed, 2014-01-22 at 16:39 +0000, Ian Campbell wrote:
> Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

Actually, it turns out that this is still kind of annoying since I need
to explicitly say OSSTEST_CONFIG=~/.xen-osstest/config, which is
different to all the other scripts (at least the ones I've used)

Would it be safe to change this default (or better yet, libraryize it)?
Something would need to set OSSTEST_CONFIG=production-config for the
cronjobs, not sure where best to do it though (in crontab?)

> ---
>  cri-args-hostlists | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cri-args-hostlists b/cri-args-hostlists
> index 9f34e4a..4f7ddf2 100644
> --- a/cri-args-hostlists
> +++ b/cri-args-hostlists
> @@ -17,7 +17,7 @@
>  # along with this program.  If not, see <http://www.gnu.org/licenses/>.
>  
> 
> -export OSSTEST_CONFIG=production-config
> +export OSSTEST_CONFIG=${OSSTEST_CONFIG:-production-config}
>  
>  check_stop_core () {
>       if [ "x$OSSTEST_IGNORE_STOP" = xy ]; then return; fi



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel