[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] Re: [Xen-devel] [PATCH] sysctl: annotate struct pm_cx_stat's pc[]/cc[]
On Wed, 2014-03-19 at 15:57 +0000, Jan Beulich wrote: > Suggested-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> > Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx> Assuming you will apply yourself once you have sufficient acks etc. > --- a/xen/include/public/sysctl.h > +++ b/xen/include/public/sysctl.h > @@ -228,8 +228,15 @@ struct pm_cx_stat { > XEN_GUEST_HANDLE_64(uint64) residencies; /* Cx residencies */ > uint32_t nr_pc; /* entry nr in pc[] */ > uint32_t nr_cc; /* entry nr in cc[] */ > - XEN_GUEST_HANDLE_64(uint64) pc; /* 1-biased indexing */ > - XEN_GUEST_HANDLE_64(uint64) cc; /* 1-biased indexing */ > + /* > + * These two arrays may (and generally will) have unused slots; slots not > + * having a corresponding hardware register will not be written by the > + * hypervisor. It is therefore up to the caller to put a suitable > sentinel > + * into all slots before invoking the function. > + * Indexing is 1-biased (PC1/CC1 being at index 0). > + */ > + XEN_GUEST_HANDLE_64(uint64) pc; > + XEN_GUEST_HANDLE_64(uint64) cc; > }; > > struct xen_sysctl_get_pmstat { > > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@xxxxxxxxxxxxx > http://lists.xen.org/xen-devel _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxx http://lists.xen.org/xen-devel
|
Lists.xenproject.org is hosted with RackSpace, monitoring our |