Re: [Xen-devel] [PATCH v3 7/7] systemd: add support initial xen systemd service files

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-03-21 at 11:16 +0000, Ian Jackson wrote:
> Luis R. Rodriguez writes ("Re: [PATCH v3 7/7] systemd: add support initial 
> xen systemd service files"):
> > On Thu, Mar 20, 2014 at 3:10 PM, M A Young <m.a.young@xxxxxxxxxxxx> wrote:
> > > You need both lines in both xenstored.service and oxenstored.service. This
> > > reflects this commit
> > > http://xenbits.xenproject.org/gitweb/?p=xen.git;a=commit;h=02ebea7768fe723deaa56c2cfcb860874544b47d
> > > adding the second line to the xencommons init.d scripts between xen 4.3 
> > > and
> > > xen 4.4 . I know from testing that you can have trouble starting guests 
> > > with
> > > xl if you leave the second line out.
> > 
> > 
> > Ok thanks for the clarification, will respin and add both, with - prefix.
> 
> Surely this code should appear exactly once in the tree.

Certainly exactly once in a given set of init system integration!

I don't want block the addition of such integration based on a plan to
eventually have some sort of common meta initscript system, but in this
particular case a common $libexec/xenstored script which the sysvinit
scripts and systemd services (and any other initscript) can call seems
like a reasonable thing to do.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel