Re: [Xen-devel] [PATCH OSSTEST v2 2/4] import enable-xen-config from xen.git, use for ts-kernel-build

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-03-20 at 16:02 +0000, Ian Campbell wrote:
> On Thu, 2014-03-20 at 16:01 +0000, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH OSSTEST v2 2/4] import enable-xen-config from 
> > xen.git, use for ts-kernel-build"):
> > > I plan to remove it from xen.git. Take the version from a03984e7bcdf which
> > > hasn't changed since 8dedf6431393 in 2010.
> > > 
> > > Update ts-kernel-build to not require xen.git.
> > > 
> > > config_intree_buildconfigs was unused so remove it.
> > 
> > Acked-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
> > 
> > Although:
> > 
> > > +    
> > > target_putfilecontents_stash($ho,1000,enable_xen_config(),"$builddir/enable-xen-config");
> > 
> > Firstly, that line could do with wrapping, and secondly, do you really
> > expect this to take 1ks ?  100s seems more like it ...
> 
> 1000 came from the line I cargo culted it from ;-)
> 
> I'll wrap and reduce to 100 as I commit, unless your comments elsewhere
> necessitate a resend anyway.

You acked everything else, so I applied making these changes as I went.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel