Re: [Xen-devel] [PATCH v2] tools/libxl: libxl_get_scheduler should return an int

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-03-21 at 12:25 +0000, Julien Grall wrote:
> libxl_get_scheduler returns either a valid value in enum range or ERROR_FAIL.
> 
> As function return type is an enum, chekcing if the value is negative will

"checking"

> be always false. Therefore both GCC and clang will never go to the error
> case.

Are there any API compatibility concerns here? I think there isn't
because
        enum foo bar = get_foo()
and
        int bar = get_foo()
are both always valid whether get_foo() returns an enum foo or an int.

So I think we can make this change without a LIBXL_HAVE define. Would be
good to confirm and include the rationale in the commit log.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel