[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2] tools/libxl: libxl_get_scheduler should return an int



Ian Campbell writes ("Re: [PATCH v2] tools/libxl: libxl_get_scheduler should 
return an int"):
> Are there any API compatibility concerns here? I think there isn't
> because
>       enum foo bar = get_foo()
> and
>       int bar = get_foo()
> are both always valid whether get_foo() returns an enum foo or an int.

Indeed.  In theory there might be code which relies on this enum being
an unsigned type but it is much more likely that any other code where
the meaning changes was wrong before and will be right afterwards.

> So I think we can make this change without a LIBXL_HAVE define. Would be
> good to confirm and include the rationale in the commit log.

Yes.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.