Re: [Xen-devel] [V8 PATCH 6/8] pvh dom0: allow get_pg_owner for translated domains

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 22.03.14 at 02:39, <mukesh.rathor@xxxxxxxxxx> wrote:
> With pvh, a translated domain, get_pg_owner must allow foreign mappings.

And what about HVM domains? Can you really safely drop this namely
with the possible use of this function in an earlier patch of this series?
(Without that new use, the change of course is safe assuming that
PV domains are never translated; I'm not sure however whether this
is being explicitly guaranteed anywhere these days, or just "a fact").

Jan

> Signed-off-by: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
> ---
>  xen/arch/x86/mm.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/xen/arch/x86/mm.c b/xen/arch/x86/mm.c
> index fcd3178..27ac807 100644
> --- a/xen/arch/x86/mm.c
> +++ b/xen/arch/x86/mm.c
> @@ -2810,12 +2810,6 @@ static struct domain *get_pg_owner(domid_t domid)
>          goto out;
>      }
>  
> -    if ( unlikely(paging_mode_translate(curr)) )
> -    {
> -        MEM_LOG("Cannot mix foreign mappings with translated domains");
> -        goto out;
> -    }
> -
>      switch ( domid )
>      {
>      case DOMID_IO:
> -- 
> 1.8.3.1




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel