Re: [Xen-devel] [PATCH v4 05/10] xen/arm: keep track of the GICH_LR used for the irq in struct pending_irq

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Fri, 21 Mar 2014, Ian Campbell wrote:
> On Fri, 2014-03-21 at 16:19 +0000, Stefano Stabellini wrote:
> > On Fri, 21 Mar 2014, Ian Campbell wrote:
> > > On Wed, 2014-03-19 at 12:32 +0000, Stefano Stabellini wrote:
> > > 
> > > Strictly you are tracking the last LR which this interrupt was in, since
> > > you don't clear p->lr AFAICT. Maybe this is OK and things never get
> > > confused by it, but it might have surprising results...
> > 
> > Actually the patch is clearing p->lr by setting it to nr_lrs, that of
> > course is invalid.
> 
> Ah, that is a bit non-obvious. Better would be
>         #define INVALID_LR ~(type_t)0
> and use that.

Yeah, this is a good idea, I'll make the change.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel