[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 1/3] xen/arm: Move p2m context save/restore in a separate function

On 03/28/2014 12:47 PM, Ian Campbell wrote:
> On Fri, 2014-03-28 at 12:44 +0000, Julien Grall wrote:
>> Hi Ian,
>> On 03/21/2014 09:19 AM, Ian Campbell wrote:
>>> On Thu, 2014-03-20 at 17:59 +0000, Julien Grall wrote:
>>>>> Are all of these isb()s necessary?  I guess this is only code motion,
>>>>> so in any case, Acked-by: Tim Deegan <tim@xxxxxxx> (for the whole series)
>>>>> but it seems like at least the one after the VTTBR write could go?
>>>> Thanks for the review.
>>>> Yes, the isb() right after VTBBR can be removed.
>>> Actually I think there are probably loads of barriers in the context
>>> switch path which can be dropped in favour of a final one at the end,
>>> not all that much stuff there relies on stuff which is reloaded before
>>> it (of course we should keep barriers for cases where there is a
>>> dependence).
>> Sorry for the late answer. Shall I rework this patch and remove the
>> duplicated isb and HCR_VM?
> If you need to rebase/resend for some other reason then please fold this
> in. If not then please send a follow up patch.

I will send a separate patch to remove unnecessary code in this function.

Julien Grall

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.