Re: [Xen-devel] [PATCH] x86/P2M: pass on errors from p2m_set_entry()

[Tim Deegan <tim@xxxxxxx>]

At 11:49 +0100 on 25 Apr (1398422989), Jan Beulich wrote:
> @@ -719,8 +719,9 @@ p2m_type_t p2m_change_type(struct domain
>      gfn_lock(p2m, gfn, 0);
>  
>      mfn = p2m->get_entry(p2m, gfn, &pt, &a, 0, NULL);
> -    if ( pt == ot )
> -        p2m_set_entry(p2m, gfn, mfn, PAGE_ORDER_4K, nt, p2m->default_access);
> +    if ( pt == ot &&
> +         p2m_set_entry(p2m, gfn, mfn, PAGE_ORDER_4K, nt, 
> p2m->default_access) )
> +        pt = p2m_invalid;

While I can see we want to do something on error here, think this
is a bit weird.  It would be better just to make this function return
bool, since every caller just tests the result for ==ot anyway.
(Well, the HVMOP_set_mem_type hanlder printks it but I don't think it's
that helpful.)

Cheers,

Tim.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel