[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH v2 1/8] tools: libxl: use uint64_t not unsigned long long for addresses



On Wed, 2014-04-30 at 16:49 +0100, Ian Campbell wrote:
> On Wed, 2014-04-30 at 16:12 +0100, Ian Jackson wrote:
> > Ian Campbell writes ("[PATCH v2 1/8] tools: libxl: use uint64_t not 
> > unsigned long long for addresses"):
> > > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > 
> > If we are going to be doing this, why not introduce a type alias or
> > two ?
> 
> Good point. I'll do that.

Actually, when I came to look at this I realised that because these
numbers are being fed into device tree it is much simpler if they are of
a fixed size rather than semantic type because you need to declare
upfront the number of 32-bit cells each address and size value in the
tree takes and it's much simpler to just declare up from "everything is
2 cells" and then use uint64_t throughout.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.