Re: [Xen-devel] [PATCH 08/12] tools/hotplug: use XEN_SCRIPT_DIR instead of hardcoded path

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-24 at 10:36 +0200, Olaf Hering wrote:
> @@ -45,11 +46,15 @@ install: all install-initd install-scripts install-udev
>  install-initd:
>       [ -d $(DESTDIR)$(INITD_DIR) ] || $(INSTALL_DIR) $(DESTDIR)$(INITD_DIR)
>       [ -d $(DESTDIR)$(SYSCONFIG_DIR) ] || $(INSTALL_DIR) 
> $(DESTDIR)$(SYSCONFIG_DIR)
> -     $(INSTALL_PROG) $(XENDOMAINS_INITD) $(DESTDIR)$(INITD_DIR)
> +     set -e; for i in $(XEN_INIT_SCRIPTS); \
> +         do \
> +             o="$(DESTDIR)$(INITD_DIR)/$$i"; \
> +             sed 's|@@XEN_SCRIPT_DIR@@|$(XEN_SCRIPT_DIR)|g' \
> +             init.d/$$i > "$$o"; \
> +             chmod 755 "$$o"; \
> +     done

I'm not entirely comfortable with doing this sort of thing at install,
rather than build, time. It has subtle issues with partial success and
the chmod etc.

I think you should rename all the input files foo.in and generate foo
from that at build time, then install as normal here using INSTALL_PROG.

Don't forget to update .*ignore.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel