Re: [Xen-devel] [PATCH 12/12] remove obsolete SUBSYS_DIR variable

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2014-04-24 at 10:36 +0200, Olaf Hering wrote:
> /var/run is a runtime directory. It is not supposed to be packaged. The
> xendomains runlevel script checks at runtime if /var/run/subsys or
> /var/run has to be used. Remove the unused SUBSYS_DIR variable from
> Config.mk and distro_mapping.txt.
> 
> Signed-off-by: Olaf Hering <olaf@xxxxxxxxx>
> ---
>  Config.mk                    | 1 -
>  docs/misc/distro_mapping.txt | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/Config.mk b/Config.mk
> index d8fe87b..3cc1ab1 100644
> --- a/Config.mk
> +++ b/Config.mk
> @@ -75,7 +75,6 @@ endef
>  
>  # See distro_mapping.txt for other options
>  $(eval $(call setvar_dir,CONFIG_LEAF_DIR,,/etc/sysconfig,sysconfig,default))
> -$(eval $(call setvar_dir,SUBSYS_DIR,/var/run,/subsys,/subsys,))
>  $(eval $(call setvar_dir,INITD_DIR,/etc,/rc.d/init.d,/rc.d/init.d,/init.d))
>  
>  ifneq ($(EXTRA_PREFIX),)
> diff --git a/docs/misc/distro_mapping.txt b/docs/misc/distro_mapping.txt
> index f56e281..f849d07 100644
> --- a/docs/misc/distro_mapping.txt
> +++ b/docs/misc/distro_mapping.txt

I think you also want to remove the comment from xendomains:
        # See docs/misc/distro_mapping.txt
        if [ -d /var/lock/subsys ]; then
                LOCKFILE=/var/lock/subsys/xendomains
        else
                LOCKFILE=/var/lock/xendomains
        fi

Other than that I think this one can go in independently of the rest of
this series, right?



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel