Re: [Xen-devel] [PATCH 07/12 v4] tools/pygrub: store kernels in /var/run/xen/pygrub

[Olaf Hering <olaf@xxxxxxxxx>]

On Fri, May 02, Ian Campbell wrote:

> On Thu, 2014-04-24 at 14:12 +0200, Olaf Hering wrote:
> > Move location of temporary bootfiles from /var/run/xend/boot to
> > /var/run/xen/pygrub. Create the subdirectory if does not exist, unless
> > --output-directory=<dir> was specified.
> 
> I'm not at all opposed to this change but why this last condition? Any
> reason not to always create the directory if it doesn't exist?
> 
> Or should there be an existence check when you specify
> --output-directory?

Without --output-directory the default should be created internally.
With --output-directory the specified dir should exist already.
Perhaps new code can be added to check if the given path is a directory.


Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel