Re: [Xen-devel] [PATCH] libxl: fix cirrus vga video memory setting with upstream qemu

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Sat, 2014-04-19 at 14:16 +0200, Fabio Fantoni wrote:
> Reading one qemu-devel post seems that setting video memory of
> cirrus vga with upstream qemu is wrong even if not show errors.

You later provided links but I think the conversation should be
referenced here.

Is this change correct for all versions of mainline qemu which people
might be using with Xen?

Please can you also explain what "wrong" means? Does it crash? Does it
silently ignore the setting? Does it do something else "wrong"? How bad
is it?

> Signed-off-by: Fabio Fantoni <fabio.fantoni@xxxxxxx>
> 
> ---
> 
> Note:
> - when this patch will be accepted upstream should be
>   backported also on xen 4.4

I think this very much depends on what you mean by "wrong" above.

> - with this qemu parameters seems correct but for further
>   confirmation I posted a question about it:
> http://lists.xen.org/archives/html/xen-devel/2014-04/msg02606.html

Any reply to this question?

Anthony, Stefano: Opinions on this change?

> ---
>  tools/libxl/libxl_dm.c |    5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c
> index 8abed7b..90f19b7 100644
> --- a/tools/libxl/libxl_dm.c
> +++ b/tools/libxl/libxl_dm.c
> @@ -508,9 +508,8 @@ static char ** 
> libxl__build_device_model_args_new(libxl__gc *gc,
>              flexarray_append_pair(dm_args, "-device", "VGA");
>              break;
>          case LIBXL_VGA_INTERFACE_TYPE_CIRRUS:
> -            flexarray_append_pair(dm_args, "-device", "cirrus-vga");
> -            flexarray_append_pair(dm_args, "-global",
> -                GCSPRINTF("vga.vram_size_mb=%d",
> +            flexarray_append_pair(dm_args, "-device",
> +                GCSPRINTF("cirrus-vga,vgamem_mb=%d",
>                  libxl__sizekb_to_mb(b_info->video_memkb)));
>              break;
>          case LIBXL_VGA_INTERFACE_TYPE_NONE:



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel