Re: [Xen-devel] [PATCH OSSTEST v2 07/15] TestSupport: allow caller of prepareguest_part_xencfg to specify viftype

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 12:28 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 07/15] TestSupport: allow caller of 
> prepareguest_part_xencfg to specify viftype"):
> > Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
> > ---
> >  Osstest/TestSupport.pm | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm
> > index 132e8e9..9d5762f 100644
> > --- a/Osstest/TestSupport.pm
> > +++ b/Osstest/TestSupport.pm
> > @@ -1419,12 +1419,13 @@ sub prepareguest_part_xencfg ($$$$$) {
> >      my $onpoweroff= $xopts->{OnPowerOff} || 'destroy';
> >      my $oncrash= $xopts->{OnCrash} || 'preserve';
> >      my $vcpus= guest_var($gho, 'vcpus', $xopts->{DefVcpus} || 2);
> > +    my $viftype= "type=$xopts->{viftype}," if $xopts->{DefVcpus};
> 
> Why is this conditional on DefVcpus ?

I think I wasn't concentrating and read the line above... It should have
been viftype to match the line bellow.

> > +    $xopts{'viftype'} ||= "ioemu";
> 
> The other xopts have CamelCase names.  And you don't need to quote it
> there.

Ack.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel