Re: [Xen-devel] [PATCH OSSTEST v2 12/15] distros: support PV guest install from Debian netinst media.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 15:01 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH OSSTEST v2 12/15] distros: support PV guest 
> install from Debian netinst media."):
> > +sub setup_netinst($$$)
> > +{
> ...
> > +    # Use the MD5SUMs file as an index
> > +    logm("Fetch index from $baseurl/MD5SUMS");
> > +    open C, "curl $baseurl/MD5SUMS|" or die "curl: $!";
> 
> This needs to be done in a way that has a timeout.  I don't know what
> curl's default is but I think it would be best to arrange to use cmd
> in TestSupport.pm somehow.  (Maybe directly, in which case it needs to
> be exported.)

I'll investigate.

Is doing this from the test controller OK, moving it to the test dom0
would nicely fix thistoo.

> > +    target_cmd_root($ho, <<END, 3600);
> > +    cd $didir && jigdo-lite --noask $netinst_jigdo
> > +END
> 
> Can you indent the script line so this is easier to read ?

Yes.

> > +    store_runvar("$gho->{Guest}_netinst_jigdo", $netinst_jigdo);
> > +
> > +    return (<<END, "\"file:$didir/$filebase.iso,xvdd:cdrom,r\",");
> > +bootloader = "pygrub"
> > +bootloader_args = ["--kernel=$props->{IsoPath}/vmlinuz", 
> > "--ramdisk=$props->{IsoPath}/initrd.gz"]
> 
> Could be wrapped.

Ack.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel