Re: [Xen-devel] [PATCH OSSTEST v2 11/15] distros: attempt pvgrub support for PV Wheezy too.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 15:19 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH OSSTEST v2 11/15] distros: attempt pvgrub 
> support for PV Wheezy too."):
> > On Fri, 2014-05-02 at 14:11 +0100, Ian Jackson wrote:
> > >   (As were the "" before.  Not sure why they were there.)
> > 
> > Does the quoting of the termination marker have an impact on the way
> > things within the heredoc are interpreted?
> 
> Yes, but "" is the same as no quoting.  Saying <<'EOF' prevents
> variable interpolation.

Ah, "" is the same as no quoting is what I forget.

> > > > -    my $extra_packages = "pv-grub-menu" if $xopts{PvMenuLst};
> > > > +    $xopts{EnableBackports} = 1
> > > > +       if $xopts{PvMenuLst} and $suite eq "wheezy";
> > > 
> > > I normally write this as   $suite =~ m/wheezy/
> > 
> > OK. (But OOI why?)
> 
> It makes it easier to add |jessie when the problem remains unfixed.
> (Also if someone has some kind of derivative called "wheezy-blarf", it
> is more likely to be right than the exact match.)

Lets hope we never have a legitimate release which is a super/substring
of another ;-) (at least bo and other dead short ones are long ago).



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel