Re: [Xen-devel] [PATCH v3 6/8] tools: arm: refactor code to setup guest p2m and fill it with RAM

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Fri, 2014-05-02 at 15:42 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH v3 6/8] tools: arm: refactor code to setup guest 
> p2m and fill it with RAM"):
> ...
> > +static int populate_guest_memory(struct xc_dom_image *dom,
> > +                                 xen_pfn_t base_pfn, xen_pfn_t nr_pfns)
> > +{
> > +    int rc;
> > +    xen_pfn_t allocsz, pfn;
> > +
> > +    if (!nr_pfns)
> > +        return 0;
> 
> Why bother with this early return ?

Mainly it just avoids the DOMPRINTF, which once we add a second bank
would be redundant a lot of the time.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel