Re: [Xen-devel] [PATCH V9 08/12] remus: implement the API to buffer/release packages

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Shriram Rajagopalan writes ("Re: [PATCH V9 08/12] remus: implement the API to 
buffer/release packages"):
> On Wed, Apr 23, 2014 at 11:10 AM, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
> wrote:

>     Are these names "tc_" not possibly clashing with some future kernel
>     things ?
> 
> These are local enums. They have nothing to do with the sch_plug
> qdisc in the kernel.

Right.  All I want to know is whether the kernel is likely to
introduce its own meanings for these names.  (I haven't looked at the
kernel headers in any detail.)  The kernel has historically been a bit
cavalier about namespacing.

If the kernel might think it owns the tc_* bit of the namespace then
we should avoid it.  If the kernel isn't likely to think that then
it's good as it is.

> That said, I agree that they could be renamed to
> something more local:
>  netbuf_begin_next_epoch /* start buffering pkts for next epoch */
>  netbuf_commit_prev_epoch  /* release buffered pkts from prev epoch, after

But probably we don't need to go so far !  Short names are generally a
good thing too.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel